Differential D1437

Fix build kwin with new glibc/qt
AbandonedPublic
Actions

Authored by graesslin on Apr 17 2016, 4:21 PM.

Details

Reviewers
stalkerg
Summary

After update glibc to 2.23 and qt for 5.6.0 build kwin is failed.
Main reason in that gcc can not find major and minor functions. (http://linux.die.net/man/3/major)
After small investigation I understood why is happen. Major and minor function declaration in sysmacros.h and nobody include their. Not in sys/* and not in kde or qt headers.

That simple patch added include sysmacros.h to source.

PS I was try find glibc changes who resulted in situation but I am failed.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
stalkerg updated this revision to Diff 3390.Apr 17 2016, 4:21 PM
stalkerg retitled this revision from to Fix build kwin with new glibc/qt.
stalkerg updated this object.
stalkerg edited the test plan for this revision. (Show Details)
stalkerg set the repository for this revision to R108 KWin.
stalkerg added a subscriber: graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2016, 4:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Apr 18 2016, 5:20 AM
graesslin edited edge metadata.

Good catch! Best push to Plasma/5.6

This revision is now accepted and ready to land.Apr 18 2016, 5:20 AM
graesslin commandeered this revision.Apr 22 2016, 12:22 PM
graesslin edited reviewers, added: stalkerg; removed: graesslin.

See:
commit 03f4f972d6c3ed03eab04c889248d089d317d370
Author: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
Date: Sat Apr 16 21:39:35 2016 +0200

Fix build with future glibc (major/minor macros)

See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html

REVIEW: 127662
This revision now requires review to proceed.Apr 22 2016, 12:22 PM
graesslin abandoned this revision.Apr 22 2016, 12:23 PM
stalkerg edited edge metadata.Apr 22 2016, 1:00 PM

Brrr what happened? :)

graesslin added a comment.Apr 22 2016, 1:34 PM
In D1437#27157, @stalkerg wrote:

Brrr what happened? :)

A similar patch already went in and I marked this one as done.

Revision Contents
Changeset List

PathPackages
Mlogind.cpp (1 line)
Mvirtual_terminal.cpp (1 line)

Diff 3390

View Options

logind.cpp

Loading...
View Options

virtual_terminal.cpp

Loading...