Differential D14355

Fix: systemsettings with breeze-dark theme
AbandonedPublic
Actions

Authored by ppavel on Jul 25 2018, 7:33 AM.

Details

Reviewers
davidedmundson
Summary

Black category title text is displayed on black background in sidebar when theme is breeze-dark. See picture.

Test Plan

Select Breeze-dark theme.
Open systemsettings.

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
ppavel created this revision.Jul 25 2018, 7:33 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 7:33 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ppavel requested review of this revision.Jul 25 2018, 7:33 AM
broulik added a subscriber: broulik.Jul 25 2018, 9:41 AM

Thanks a lot for your patch!

This patch souldn't be neccessary, however, as QtControls2.Label should do that automatically. Can you check you have qqc2-desktop-style installed? What's the Kirigami version?

ppavel added a comment.Jul 25 2018, 9:57 AM

With qqc2-desktop-style installed all works fine. My fail.

broulik added a comment.Jul 25 2018, 10:14 AM

I wonder why that package wasn't installed, though, I thought it was a dependency of Kirigami or Plasma these days. Perhaps file a bug about this to your distribution.
You can abandon this revision then, thanks again.

ppavel abandoned this revision.Jul 25 2018, 11:31 AM

Revision Contents
Changeset List

Diff 38383

View Options

sidebar/package/contents/ui/CategoriesPage.qml

Loading...