Lessen indent before "Send files" in main activity
ClosedPublic

Authored by lennarts on Jul 24 2018, 10:26 PM.

Details

Summary

The "Send files" button in main acitivity if connected has a larger
indent then the other buttons. This happens on most pixel densities.
Reason was the larger icon the "Send files" button has.

With this patch, the icons all have the same pixel dimensions. It
solves the too large indent.

Screenshot (Because of translation, "Send files" is translated to
"Dateien senden"):

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lennarts created this revision.Jul 24 2018, 10:26 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJul 24 2018, 10:26 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
lennarts requested review of this revision.Jul 24 2018, 10:26 PM
apol requested changes to this revision.Jul 26 2018, 5:59 PM
apol added a subscriber: apol.

The patch doesn't apply here, but the change is sound. Please upload it and we'll land it.

This revision now requires changes to proceed.Jul 26 2018, 5:59 PM
lennarts updated this revision to Diff 38731.Jul 29 2018, 9:32 PM
lennarts updated this revision to Diff 38732.Jul 29 2018, 9:46 PM

Sorry this was my first time with phabricator, hope it is correct now :)

nicolasfella accepted this revision.Jul 29 2018, 10:33 PM
nicolasfella added a subscriber: nicolasfella.

Nice, thanks!

If you are looking for something to do next: The icon appears to be a bit darker than the rest, they should have the same color.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 29 2018, 10:34 PM
This revision was automatically updated to reflect the committed changes.