Differential D1426

Rework SessionLock logic so it would work without D-Bus.
ClosedPublic
Actions

Authored by arrowd on Apr 15 2016, 5:36 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Maniphest Tasks
T1339: Windows: Make sure we don't start/use dbus-daemon
Test Plan

All tests of test_sessionmanager pass with and without D-Bus.

Diff Detail

Repository
R33 KDevPlatform
Branch
sessioncontroller
Lint
No Linters Available
Unit
No Unit Test Coverage
arrowd updated this revision to Diff 3369.Apr 15 2016, 5:36 PM
arrowd retitled this revision from to Rework SessionLock logic so it would work without D-Bus..
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 15 2016, 5:36 PM
kfunk requested changes to this revision.Apr 18 2016, 9:25 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

I'll run the unit test on Linux after you fixed above issues.

Thanks!

shell/sessionlock.cpp
83–84

const

84

const

98

Simplify: a ? b : false => a && b

104

a ? b : true => !a || b

106

Dito, same below

This revision now requires changes to proceed.Apr 18 2016, 9:25 AM
arrowd updated this revision to Diff 3396.Apr 18 2016, 9:52 AM
arrowd edited edge metadata.
arrowd marked 5 inline comments as done.

Address comments

kfunk accepted this revision.Apr 18 2016, 10:22 AM
kfunk edited edge metadata.

Test still works on Linux -> LGTM

This revision is now accepted and ready to land.Apr 18 2016, 10:22 AM
arrowd closed this revision.Apr 18 2016, 10:38 AM

Closed by commits

kdevplatform (5.0) v4.90.91-191-gcef2f8d * Gleb Popov: tests/autotestshell.cpp
Set KDE_FORK_SLAVES env var in the test shell too.
http://commits.kde.org/kdevplatform/cef2f8d1e09b607fedb1cfe1394f3c491b25ee24

kdevplatform (5.0) v4.90.91-192-gbf62036 * Gleb Popov: shell/sessionlock.cpp
Rework SessionLock logic so it would work without D-Bus.
http://commits.kde.org/kdevplatform/bf62036c8f4be79ee3c5d465c678f4214d248744

Revision Contents
Changeset List

PathPackages
Mshell/sessionlock.cpp (12 lines)
Mtests/autotestshell.cpp (4 lines)

Diff 3396

View Options

shell/sessionlock.cpp

Loading...
View Options

tests/autotestshell.cpp

Loading...