Flush Xwayland connection only when events were filtered
AbandonedPublic
Actions

Authored by romangg on Jul 20 2018, 4:24 PM.

Details

Reviewers

None

Group Reviewers

KWin

Summary

When no events were filtered, the connection does not need to be flushed. This
is a small performance optimization.

Test Plan

Compiles.

Repository

R108 KWin

Branch

onlyFlushOnFilter

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1039
Build 1052: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptJul 20 2018, 4:24 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Jul 20 2018, 4:24 PM

graesslin added inline comments.

main_wayland.cpp
227	Your assumption might be wrong: updating the X11 time might return false, but might require to flush the connection.

main_wayland.cpp
227	I have tested it now over the weekend and didn't have any problems. Could you give an example of a time update requiring a flush?

Cleanup. Optimization not necessary and there could be unknown problems.

			Path	Packages
M			main_wayland.cpp (7 lines)

Commit	Tree	Parents	Author	Summary	Date
08f05b27b756	c8373bcb7596	afc80f8bd5bd	Roman Gilg	Flush Xwayland connection only when events were filtered (Show More…)	Jul 20 2018, 4:21 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38144	afc80f8		Jul 20 2018, 4:24 PM	★	★