Differential D14214

[Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu
ClosedPublic
Actions

Authored by SGOrava on Jul 18 2018, 5:13 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:6556ade5c98a: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu
Summary

FEATURE: 394247

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SGOrava created this revision.Jul 18 2018, 5:13 PM
Restricted Application added a project: Falkon. · View Herald TranscriptJul 18 2018, 5:13 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
SGOrava requested review of this revision.Jul 18 2018, 5:13 PM
drosca requested changes to this revision.Jul 18 2018, 7:06 PM
drosca added a subscriber: drosca.
drosca added inline comments.
src/plugins/VerticalTabs/tabtreeview.cpp
390

You don't need to save it in vector because unloading tab doesn't change the tab tree (while closing the tab does, so that's why is it done like that there).

This revision now requires changes to proceed.Jul 18 2018, 7:06 PM
SGOrava updated this revision to Diff 38038.Jul 18 2018, 7:20 PM

Update according to review

drosca accepted this revision.Jul 19 2018, 3:36 PM
This revision is now accepted and ready to land.Jul 19 2018, 3:36 PM
Closed by commit R875:6556ade5c98a: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu (authored by SGOrava, committed by drosca). · Explain WhyJul 19 2018, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38098

View Options

src/plugins/VerticalTabs/tabtreeview.cpp

Loading...