Differential D14170

milou: Fix build error
ClosedPublic
Actions

Authored by alistairf on Jul 16 2018, 8:55 PM.

Details

Reviewers
vkrause
Commits
R869:6cbdda083200: milou: Fix build error
Summary

To fix:
error: 'QTextStream' was not declared in this scope

QTextStream stream(&file)

apply a patch that has been accepted (but not merged) in the upstream
project.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Diff Detail

Repository
R869 Yocto: KDE Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alistairf requested review of this revision.Jul 16 2018, 8:55 PM
alistairf created this revision.
vkrause accepted this revision.Jul 17 2018, 6:58 AM

Thanks for also upstreaming the patch!
I'll look into integrating your patches tonight, once my pending KF5 5.48.0 and Plasma 5.13.3 updates are integrated.

This revision is now accepted and ready to land.Jul 17 2018, 6:58 AM
broulik added a subscriber: broulik.Jul 17 2018, 9:39 AM

I thought the preview stuff in milou was dead but apparently it's still being built despite being unused

Closed by commit R869:6cbdda083200: milou: Fix build error (authored by alistairf, committed by vkrause). · Explain WhyJul 17 2018, 6:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37981

View Options

recipes-plasma/milou.inc

Loading...
View Options

recipes-plasma/milou/0001-textplugin-Fix-missing-QTextStream-include.patch

Loading...