| muhlenpfordt |
| Gwenview |
D14093 will add back middle-clicking to toggle between Fit (with
F as its keyboard shortcut) and 100% zoom. In addition,
D14094 sets ⇧+F as a shortcut for Fill.
Going along with this, here we add ⇧-middle-clicking for
Fill. The code is moved to DocumentView in order not to
duplicate the handling of the toggling behaviour.
We also adapt the docbook accordingly, as some users still seem to read
the manual.
CCBUG: 396360
Depends on D14093
Middle-click multiple times on an image in View mode and observe
Fit is toggled. Repeat while holding down ⇧ for
Fill.
Proof-read docbook ("View mode" and "Tips" sections).
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| lib/documentview/documentview.cpp | ||
|---|---|---|
| 717 | I'd rather be able to write something like setZoomMode(ZoomMode::Custom, zoomLevel) or setZoomMode(ZoomMode::Fit) here… | |
Code looks good to me.
Sadly the centering to mouse position when zooming to 100% gets lost with our combination.
Should I add this to DocumentView::toggleZoomTo...()? It will work for both shortcut (maybe surprising for users?) and click.
Or add an argument to pass the mouse position only for click events?
Interesting. Is this really working for you without the patches? For me, even middle-clicking with a KDE4-based Gwenview centers instead of respecting the mouse position.
Should I add this to DocumentView::toggleZoomTo...()? It will work for both shortcut (maybe surprising for users?) and click.
Or add an argument to pass the mouse position only for click events?
I think it would be great to get this working for both clicking and the keyboard shortcuts, see my comment in D14093#291581. (I'm not sure how well this will work for the shortcut case when the cursor is outside the viewport. If it is confusing maybe in that case there could be a fallback to the center, but let's try without the fallback first.)
I never saw it not working. No matter what Kubuntu version I used, up to 18.04 (Frameworks 5.44 / Qt 5.9.5).
I think it would be great to get this working for both clicking and the keyboard shortcuts, see my comment in D14093#291581. (I'm not sure how well this will work for the shortcut case when the cursor is outside the viewport. If it is confusing maybe in that case there could be a fallback to the center, but let's try without the fallback first.)
It's not easy to map the current mouse position from global QCursor::pos() in a QGraphicsWidget.
But finally found a way in the Qt source. :)
Tested with the updated master and it works great now.
(Centering to cursor on Fill to be done.)