IncrementalSearchBox: do not propagate unhandled keys to parent
ClosedPublic

Authored by mglb on Jul 11 2018, 2:10 AM.

Details

Summary

When the focus is in IncrementalSearchBar, unhandled keys (i.e. those
not handled by text input box or unhandledMovementKeyPressed signal)
are sent to a program running in the terminal, which is probably not
what user expects. Example of propagated keys: Up, Down, PgUp, PgDown,
Fn, Tab.

This patch disables propagation. Shortcuts, movement keys, and keys
handled by search bar still works.

Test Plan
  • Run cat
  • Open search box
  • Press Up/Down/PgUp/PgDown/Tab/Fn keys

Actual result: keys are sent to cat
Expected result: nothing should happen (implemented)
Alternative expected result: focus should move from text input to first
button

Regression test

Following keys/shortcuts should work:

  • Shift+Up/Down/PgUp/PgDown - terminal contents scrolling
  • Ctrl+Shift+T - open new tab (unless it was changed)
  • Enter - search next
  • Esc - close search box

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb created this revision.Jul 11 2018, 2:10 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 11 2018, 2:10 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
mglb requested review of this revision.Jul 11 2018, 2:10 AM
mglb edited the summary of this revision. (Show Details)Jul 11 2018, 2:14 AM
mglb edited the test plan for this revision. (Show Details)
mglb added a reviewer: Konsole.
hindenburg accepted this revision.Jul 11 2018, 11:43 AM
This revision is now accepted and ready to land.Jul 11 2018, 11:43 AM
This revision was automatically updated to reflect the committed changes.