Differential D13999

[Kicker System Entry] Remove KDisplayManager global static
ClosedPublic
Actions

Authored by broulik on Jul 9 2018, 9:30 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:1cdb7ae4dfea: [Kicker System Entry] Remove KDisplayManager global static
R120:6458aff7a682: [Kicker System Entry] Remove KDisplayManager global static
Summary

It is only used in one place and cached, so no need for a global static that is created as soon as the plugin is loaded.

Test Plan

No longer get a KDisplayManager instance on plasmashell startup with Kickoff, only when going to the Leave tab now. Tab still works.
Kicker creates the model right away and still works.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 9 2018, 9:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2018, 9:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 9 2018, 9:30 AM
hein accepted this revision.Jul 10 2018, 8:31 PM
This revision is now accepted and ready to land.Jul 10 2018, 8:31 PM
Closed by commit R119:1cdb7ae4dfea: [Kicker System Entry] Remove KDisplayManager global static (authored by broulik). · Explain WhyJul 11 2018, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37549

View Options

applets/kicker/plugin/systementry.h

Loading...
View Options

applets/kicker/plugin/systementry.cpp

Loading...