It's only needed by the standalone x11 variant. This allows us to
simplify the creation of the OpenGLBackend: it's created by the
platform plugin - we don't need custom complex logic.
Details
Details
- Reviewers
sebas - Group Reviewers
Plasma - Commits
- R108:248991223b19: Move glxbackend to x11 standalone plugin
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| plugins/platforms/x11/standalone/x11_platform.cpp | ||
|---|---|---|
| 62 | should this ifdef not cover also the case and break lines? (So the whole case only becomes available with epoxy, and if not, there's no such branch and we fall back to default? | |
| plugins/platforms/x11/standalone/x11_platform.cpp | ||
|---|---|---|
| 62 | I also stumbled over this when moving the code. I decided to leave it as it is for the move. But yeah there is clearly a problem as it would no longer compile with the dependency missing. I'll make it fall through to default. | |
Comment Actions
Reworked the X11StandalonePlatform::createOpenGLBackend() to
compile also when HAVE_EPOXY_GLX is not set.
| plugins/platforms/x11/standalone/x11_platform.cpp | ||
|---|---|---|
| 62 | Might as well move this line up above the "case "GlxPlatformInterface:, makes it more logical. No need to supply a new patchjust for that, though. Just fix it (if you agree) and ship it. | |