Fix loading of files with 'Box' transformation filter
ClosedPublic

Authored by dkazakov on Jun 29 2018, 5:18 PM.

Details

Summary

We have released Krita with new name for the Box filter,
so now we have two variants for the name of this filer,
which is used in different places.

This patch adds aliases support for KoGenericRegistry and
makes 'Box' to be a variant for 'NearestNeighbour'

BUG:395979

Test Plan

0) Add the following section to kritarc

[KisToolTransform]
filterId=Box
  1. Start Krita
  2. Krita shouldn't crash
  3. Also try for other filter ids: Bicubic, NearestNeighbor, Bilinear

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkazakov created this revision.Jun 29 2018, 5:18 PM
Restricted Application added a project: Krita. · View Herald TranscriptJun 29 2018, 5:18 PM
dkazakov requested review of this revision.Jun 29 2018, 5:18 PM
rempt accepted this revision.Jun 30 2018, 8:08 AM

I was a bit confused at first because I thought we already had something like this, but that was the doubleEntries thing.

This revision is now accepted and ready to land.Jun 30 2018, 8:08 AM

Hi, @rempt!

It looks like doubleEntries is not used anywhere (though I guess it was initially designed for that, but then abandoned). I decided not to remove it in this patch, just to be on the safe side. I guess we can remove it as a separate patch for master-only.

This revision was automatically updated to reflect the committed changes.