The provider is checked by fetching the server config
Details
Details
Diff Detail
Diff Detail
- Repository
- R235 Attica
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :)
Apart from that, though, looks good! :) (was just about to add a comment about your invalid data string being less than descriptive... but hey, it's invalid data, why not ;) )
| src/provider.h | ||
|---|---|---|
| 275 | When adding new functions to anywhere, putting in documentation really needs to happen as well :) You've got it in other places already, though, so i'm sure that's just a minor bit of forgetfulness, these things happen :) | |