Add option to restore fullscreen state of the window

Authored by fenuks on Jun 24 2018, 9:17 PM.



Adds option to remember if yakuake window was fullscreen last time it was retracted

Diff Detail

R369 Yakuake
No Linters Available
No Unit Test Coverage
Build Status
Buildable 285
Build 285: arc lint + arc unit
fenuks requested review of this revision.Jun 24 2018, 9:17 PM
fenuks created this revision.
fenuks added a reviewer: hein.Jul 7 2018, 11:48 AM
fenuks added a subscriber: hein.
fenuks removed a subscriber: hein.

Hello, can someone take a look on this, please? :-)

i'd also like to see this merged - anything i can do to help?

i'd also like to see this merged - anything i can do to help?

Main problem is that I didn't receive any feedback from @hein on this, and waiting quite a few months already. Perhaps if you had more luck with reaching him things could move forward.

@hein thoughts? anything i can do to help move this forward?

hein accepted this revision.Feb 21 2019, 3:24 PM

Sorry for the delay! Somehow I kept missing this. Patch looks fine, do you need help merging it or do you have write access?

This revision is now accepted and ready to land.Feb 21 2019, 3:24 PM

i don't think anyone in the thread has write access, so if you could merge that would be awesome.

thanks again for the help!

Hello. I'm glad to see this merged. No, I don't have write access, thus asking for assistance.

hein added a comment.Feb 23 2019, 5:13 PM

I'm ready to push this to master - are you ok with realname attribution (Władysław Wokulski)?

Thank you. As for your question, I'm fine with just a nickname.

This revision was automatically updated to reflect the committed changes.