Differential D13709

Support MPRIS stop
ClosedPublic
Actions

Authored by nicolasfella on Jun 24 2018, 8:13 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Maniphest Tasks
T9070: Implement Stop in MPRIS plugin
Commits
R225:3e05b7080397: Support MPRIS stop
Summary

Fixes T9070

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jun 24 2018, 8:13 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJun 24 2018, 8:13 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Jun 24 2018, 8:13 PM
nicolasfella edited the summary of this revision. (Show Details)Jun 24 2018, 8:19 PM
albertvaka added a subscriber: albertvaka.Jul 26 2018, 6:03 PM

Such an obscure use case :P

Shouldn't we have a isStopAllowed() the same way we have isPlayAllowed(), isPauseAllowed(), etc? So the button is enabled/disabled depending on the player support for it (eg: Spotify only has pause).

albertvaka accepted this revision.Jul 26 2018, 6:04 PM

This can be merged anyway and implement the change when you have time.

This revision is now accepted and ready to land.Jul 26 2018, 6:04 PM
nicolasfella added a comment.Jul 26 2018, 6:14 PM

MPRIS does not have a canStop property. I guess we can extend the Spotify hack, but for other players I guess we can't do much

Closed by commit R225:3e05b7080397: Support MPRIS stop (authored by nicolasfella). · Explain WhyJul 27 2018, 5:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38545

View Options

res/drawable/ic_stop.xml

Loading...
View Options

res/layout/mpris_control.xml

Loading...
View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java

Loading...