added example images to combobox dialog dropdown grid lineedit spinbox textedit togglebutton
ClosedPublic

Authored by fabianr on Jun 23 2018, 10:35 AM.

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
component-images
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 324
Build 324: arc lint + arc unit
fabianr requested review of this revision.Jun 23 2018, 10:35 AM
fabianr created this revision.
fabianr updated this revision to Diff 36682.Jun 26 2018, 12:35 PM
  • Added borders around images and a placeholder for the lineedit
fabianr updated this revision to Diff 36683.Jun 26 2018, 12:43 PM
  • updated screenshot for lineedt to be active
romangg accepted this revision.Jun 26 2018, 1:04 PM

Maybe line edit and combobox imgs can become gifs in the future, such that the cursor flashes.

source/qml/components/lineedit/Lineedit1.qml
34

nitpick: on bindings you don't put a semicolon in the end.

This revision is now accepted and ready to land.Jun 26 2018, 1:04 PM
fabianr closed this revision.Jun 26 2018, 1:10 PM