Move GlobalWorkDir logic to AddJob::doWork()
ClosedPublic

Authored by elvisangelaccio on Apr 9 2016, 1:39 PM.

Details

Summary

With this patch, we change the working dir to GlobalWorkDir at the AddJob
level. This way is easier to restore the old working dir, and we also avoid
some duplicated code between cliinterface and libarchiveplugin.

Note that the libarchive plugin used to add trailing slashes to relative folder
paths, while CliInterface didn't. Both plugins now receive relative folders
already with a trailing slash. This doesn't seem to change how
CliInterface::addFiles works.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Move GlobalWorkDir logic to AddJob::doWork().
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a project: Ark. · View Herald TranscriptApr 9 2016, 1:39 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
  • Rebased on top of master
rthomsen accepted this revision.Apr 16 2016, 7:57 PM
rthomsen edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Apr 16 2016, 7:57 PM
This revision was automatically updated to reflect the committed changes.