Differential D13687

Move reports drawing to reports view plugin
ClosedPublic
Actions

Authored by wojnilowicz on Jun 23 2018, 6:14 AM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:ac6976abda0e: Move reports drawing to reports view plugin

Summary

This patch completes encapsulation of reporting features in KMyMoney. If a report is needed then it should be returned as:

QWidget

It will then be possible to show report outside of KReportsView and handle it completely inside KReportsView. This approach will allow us embedding any report anywhere with configuration controls built in a report.

QString

Some reports aren't graphical charts, so they need textual representation. Disadvantage of this approach is that chart cannot be handled inside KReportsView.

Test Plan

D13414 and D13581 needs to be applied first.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Jun 23 2018, 6:14 AM

wojnilowicz created this revision.

wojnilowicz updated this revision to Diff 36963.Jun 30 2018, 6:53 PM

It compiles but I spotted a problem in the graph of one of my accounts. I expect it not to be related to this patch which I verified.

kmymoney/mymoney/mymoneyaccount.cpp
371	I would nowadays name it `tradingCurrencyId`.
kmymoney/plugins/views/reports/reportsview.h
44	Can you document the parameters, esp. `arg` since it needs a specific format to be valid.
kmymoney/plugins/views/reports/reportsviewenums.h
24	I'd name this `NetWorthForecastWithArgs`

This revision now requires changes to proceed.Jul 8 2018, 8:12 AM

wojnilowicz updated this revision to Diff 37336.Jul 8 2018, 1:28 PM

wojnilowicz marked 3 inline comments as done.

tbaumgart accepted this revision as: tbaumgart.Jul 8 2018, 8:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2018, 2:33 PM

Closed by commit R261:ac6976abda0e: Move reports drawing to reports view plugin (authored by wojnilowicz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/CMakeLists.txt (3 lines)
M			kmymoney/converter/tests/converter-test.cpp (2 lines)
M			kmymoney/dialogs/CMakeLists.txt (1 line)
V			kmymoney/{dialogs → plugins/views/reports}/kbalancechartdlg.h
V			kmymoney/{dialogs → plugins/views/reports}/kbalancechartdlg.cpp
M			kmymoney/kmymoney.cpp (2 lines)
M			kmymoney/mymoney/mymoneyaccount.h (29 lines)
M			kmymoney/mymoney/mymoneyaccount.cpp (23 lines)
M			kmymoney/mymoney/storage/tests/CMakeLists.txt (1 line)
M			kmymoney/mymoney/tests/mymoneyforecast-test.cpp (2 lines)
M			kmymoney/plugins/views/CMakeLists.txt (2 lines)
M			kmymoney/plugins/views/forecast/CMakeLists.txt (2 lines)
M			kmymoney/plugins/views/forecast/kforecastview_p.h (70 lines)
M			kmymoney/plugins/views/reports/CMakeLists.txt (3 lines)
V			kmymoney/{plugins/views/reports/core ← reports}/CMakeLists.txt
V			kmymoney/{plugins/views/reports/core ← reports}/kbalanceaxis.h
V			kmymoney/{plugins/views/reports/core ← reports}/kbalanceaxis.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/kreportchartview.h
V			kmymoney/{plugins/views/reports/core ← reports}/kreportchartview.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/listtable.h
V			kmymoney/{plugins/views/reports/core ← reports}/listtable.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/objectinfotable.h
V			kmymoney/{plugins/views/reports/core ← reports}/objectinfotable.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/pivotgrid.h
V			kmymoney/{plugins/views/reports/core ← reports}/pivotgrid.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/pivottable.h
V			kmymoney/{plugins/views/reports/core ← reports}/pivottable.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/querytable.h
V			kmymoney/{plugins/views/reports/core ← reports}/querytable.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/reportaccount.h (14 lines)
V			kmymoney/{plugins/views/reports/core ← reports}/reportaccount.cpp (20 lines)
V			kmymoney/{plugins/views/reports/core ← reports}/reportdebug.h
V			kmymoney/{plugins/views/reports/core ← reports}/reporttable.h
V			kmymoney/{plugins/views/reports/core ← reports}/reporttable.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/tests/CMakeLists.txt
P			kmymoney/plugins/views/reports/core/tests/chart-test.h Copied from kmymoney/reports/tests/chart-test.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/chart-test.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/tests/kreportsview-test.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/pivotgrid-test.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/pivotgrid-test.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/tests/pivottable-test.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/pivottable-test.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/tests/querytable-test.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/querytable-test.cpp
V			kmymoney/{plugins/views/reports/core ← reports}/tests/reportstestcommon.h
V			kmymoney/{plugins/views/reports/core ← reports}/tests/reportstestcommon.cpp
V			kmymoney/{plugins/views/reports ← dialogs}/kbalancechartdlg.h
V			kmymoney/{plugins/views/reports ← dialogs}/kbalancechartdlg.cpp
M			kmymoney/plugins/views/reports/kreportsview.cpp (10 lines)
M			kmymoney/plugins/views/reports/reportsview.h (22 lines)
M			kmymoney/plugins/views/reports/reportsview.cpp (268 lines)
V			kmymoney/{plugins/views/reports/reportsviewenums.h ← reports/tests/chart-test.h} (26 lines)
V			kmymoney/{reports → plugins/views/reports/core}/CMakeLists.txt
V			kmymoney/{reports → plugins/views/reports/core}/kbalanceaxis.h
V			kmymoney/{reports → plugins/views/reports/core}/kbalanceaxis.cpp
V			kmymoney/{reports → plugins/views/reports/core}/kreportchartview.h
V			kmymoney/{reports → plugins/views/reports/core}/kreportchartview.cpp
V			kmymoney/{reports → plugins/views/reports/core}/listtable.h
V			kmymoney/{reports → plugins/views/reports/core}/listtable.cpp
V			kmymoney/{reports → plugins/views/reports/core}/objectinfotable.h
V			kmymoney/{reports → plugins/views/reports/core}/objectinfotable.cpp
V			kmymoney/{reports → plugins/views/reports/core}/pivotgrid.h
V			kmymoney/{reports → plugins/views/reports/core}/pivotgrid.cpp
V			kmymoney/{reports → plugins/views/reports/core}/pivottable.h
V			kmymoney/{reports → plugins/views/reports/core}/pivottable.cpp
V			kmymoney/{reports → plugins/views/reports/core}/querytable.h
V			kmymoney/{reports → plugins/views/reports/core}/querytable.cpp
V			kmymoney/{reports → plugins/views/reports/core}/reportaccount.h
V			kmymoney/{reports → plugins/views/reports/core}/reportaccount.cpp
V			kmymoney/{reports → plugins/views/reports/core}/reportdebug.h
V			kmymoney/{reports → plugins/views/reports/core}/reporttable.h
V			kmymoney/{reports → plugins/views/reports/core}/reporttable.cpp
V			kmymoney/{reports → plugins/views/reports/core}/tests/CMakeLists.txt
P			kmymoney/reports/tests/chart-test.h Deleted after being copied to multiple locations: kmymoney/plugins/views/reports/core/tests/chart-test.h kmymoney/plugins/views/reports/reportsviewenums.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/chart-test.cpp
V			kmymoney/{reports → plugins/views/reports/core}/tests/kreportsview-test.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/pivotgrid-test.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/pivotgrid-test.cpp
V			kmymoney/{reports → plugins/views/reports/core}/tests/pivottable-test.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/pivottable-test.cpp
V			kmymoney/{reports → plugins/views/reports/core}/tests/querytable-test.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/querytable-test.cpp
V			kmymoney/{reports → plugins/views/reports/core}/tests/reportstestcommon.h
V			kmymoney/{reports → plugins/views/reports/core}/tests/reportstestcommon.cpp
M			kmymoney/views/kaccountsview.cpp (5 lines)
M			kmymoney/views/khomeview_p.h (258 lines)
M			kmymoney/views/kmymoneyview.cpp (4 lines)
M			kmymoney/views/viewenums.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36544			Jun 23 2018, 6:13 AM	★	★
Diff 2	36963			Jun 30 2018, 6:53 PM	★	★
Diff 3	37336			Jul 8 2018, 1:28 PM	★	★
Diff 4	37456	2b780c6	R261:ac6976abda0e24d3461593e12765031298d22e0a	Jul 9 2018, 2:30 PM	★	★

Move reports drawing to reports view pluginClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 37456

kmymoney/CMakeLists.txt

kmymoney/converter/tests/converter-test.cpp

kmymoney/dialogs/CMakeLists.txt

kmymoney/dialogs/kbalancechartdlg.h

kmymoney/dialogs/kbalancechartdlg.cpp

kmymoney/kmymoney.cpp

kmymoney/mymoney/mymoneyaccount.h

kmymoney/mymoney/mymoneyaccount.cpp

kmymoney/mymoney/storage/tests/CMakeLists.txt

kmymoney/mymoney/tests/mymoneyforecast-test.cpp

kmymoney/plugins/views/CMakeLists.txt

kmymoney/plugins/views/forecast/CMakeLists.txt

kmymoney/plugins/views/forecast/kforecastview_p.h

kmymoney/plugins/views/reports/CMakeLists.txt

kmymoney/plugins/views/reports/core/CMakeLists.txt

kmymoney/plugins/views/reports/core/kbalanceaxis.h

kmymoney/plugins/views/reports/core/kbalanceaxis.cpp

kmymoney/plugins/views/reports/core/kreportchartview.h

kmymoney/plugins/views/reports/core/kreportchartview.cpp

kmymoney/plugins/views/reports/core/listtable.h

kmymoney/plugins/views/reports/core/listtable.cpp

kmymoney/plugins/views/reports/core/objectinfotable.h

kmymoney/plugins/views/reports/core/objectinfotable.cpp

kmymoney/plugins/views/reports/core/pivotgrid.h

kmymoney/plugins/views/reports/core/pivotgrid.cpp

kmymoney/plugins/views/reports/core/pivottable.h

kmymoney/plugins/views/reports/core/pivottable.cpp

kmymoney/plugins/views/reports/core/querytable.h

kmymoney/plugins/views/reports/core/querytable.cpp

kmymoney/plugins/views/reports/core/reportaccount.h

kmymoney/plugins/views/reports/core/reportaccount.cpp

kmymoney/plugins/views/reports/core/reportdebug.h

kmymoney/plugins/views/reports/core/reporttable.h

kmymoney/plugins/views/reports/core/reporttable.cpp

kmymoney/plugins/views/reports/core/tests/CMakeLists.txt

kmymoney/plugins/views/reports/core/tests/chart-test.h

kmymoney/plugins/views/reports/core/tests/chart-test.cpp

kmymoney/plugins/views/reports/core/tests/kreportsview-test.h

kmymoney/plugins/views/reports/core/tests/pivotgrid-test.h

kmymoney/plugins/views/reports/core/tests/pivotgrid-test.cpp

kmymoney/plugins/views/reports/core/tests/pivottable-test.h

kmymoney/plugins/views/reports/core/tests/pivottable-test.cpp

kmymoney/plugins/views/reports/core/tests/querytable-test.h

kmymoney/plugins/views/reports/core/tests/querytable-test.cpp

kmymoney/plugins/views/reports/core/tests/reportstestcommon.h

kmymoney/plugins/views/reports/core/tests/reportstestcommon.cpp

kmymoney/plugins/views/reports/kbalancechartdlg.h

kmymoney/plugins/views/reports/kbalancechartdlg.cpp

kmymoney/plugins/views/reports/kreportsview.cpp

kmymoney/plugins/views/reports/reportsview.h

kmymoney/plugins/views/reports/reportsview.cpp

kmymoney/plugins/views/reports/reportsviewenums.h

kmymoney/reports/CMakeLists.txt

kmymoney/reports/kbalanceaxis.h

kmymoney/reports/kbalanceaxis.cpp

kmymoney/reports/kreportchartview.h

kmymoney/reports/kreportchartview.cpp

kmymoney/reports/listtable.h

kmymoney/reports/listtable.cpp

kmymoney/reports/objectinfotable.h

kmymoney/reports/objectinfotable.cpp

kmymoney/reports/pivotgrid.h

kmymoney/reports/pivotgrid.cpp

kmymoney/reports/pivottable.h

kmymoney/reports/pivottable.cpp

kmymoney/reports/querytable.h

kmymoney/reports/querytable.cpp

kmymoney/reports/reportaccount.h

kmymoney/reports/reportaccount.cpp

kmymoney/reports/reportdebug.h

kmymoney/reports/reporttable.h

kmymoney/reports/reporttable.cpp

kmymoney/reports/tests/CMakeLists.txt

kmymoney/reports/tests/chart-test.h

kmymoney/reports/tests/chart-test.cpp

Move reports drawing to reports view plugin
ClosedPublic
Actions

Revision Contents
Changeset List