Differential D13675

Fix sage backend for Sage 8.1 and 8.2
ClosedPublic
Actions

Authored by sirgienko on Jun 22 2018, 9:35 AM.

Details

Reviewers
asemke
Commits
R55:7e4d081956a1: Fix broken sage login for Sage versions greater, than 8.0 (8.1, 8.2, etc.) and…

Diff Detail

Repository
R55 Cantor
Branch
sage-login-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 240
Build 240: arc lint + arc unit
sirgienko created this revision.Jun 22 2018, 9:35 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 22 2018, 9:35 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Jun 22 2018, 9:35 AM
sirgienko updated this revision to Diff 36546.Jun 23 2018, 7:13 AM

Set versions 8.1 and 8.2 as recommends

sirgienko updated this revision to Diff 36547.Jun 23 2018, 7:16 AM

Update error message

sirgienko updated this revision to Diff 36548.Jun 23 2018, 7:36 AM

Update comments

asemke accepted this revision.Jun 23 2018, 7:47 AM
This revision is now accepted and ready to land.Jun 23 2018, 7:47 AM
Closed by commit R55:7e4d081956a1: Fix broken sage login for Sage versions greater, than 8.0 (8.1, 8.2, etc.) and… (authored by sirgienko). · Explain WhyJun 23 2018, 8:31 AM
This revision was automatically updated to reflect the committed changes.
lbeltrame added a subscriber: lbeltrame.Jun 27 2018, 9:05 AM
lbeltrame added inline comments.
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

Why the explicit permission? This actually breaks stuff because the owner can't read this file.

Found while packaging the git version in openSUSE.

sirgienko added inline comments.Jun 27 2018, 3:20 PM
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

This file must be executable, so permissions are setted directly.
Isn't the permission WORLD_READ enough for reading by all users, including owner?

sirgienko added inline comments.Jun 27 2018, 3:33 PM
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

But, if you want, you can change permissions to rwxr-xr-x, if it solve your problem,

lbeltrame added inline comments.Jun 27 2018, 3:40 PM
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

This is what happens when I try to package this:

error: create archive failed on file /home/abuild/rpmbuild/BUILDROOT/cantor-18.07.70git.20180623T113102~7e4d0819-74.1.x86_64/usr/share/cantor/sagebackend/cantor-execsage: cpio: open failed - Permission denied

So, the permissions are wrong.

sirgienko added inline comments.Jun 27 2018, 3:42 PM
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

And with "rwxr-xr-x" all works fine?

lbeltrame added inline comments.Jun 27 2018, 9:12 PM
src/backends/sage/CMakeLists.txt
35 ↗(On Diff #36546)

No. This line was not correct, you had to use INSTALL(PROGRAMS...) and not INSTALL(FILES..). Either way, it's fixed in bcc16ae0d7d9aa08dcd77e31b7204b758f5c117c (not by me).

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 36547

View Options

src/backends/sage/CMakeLists.txt

Loading...
View Options

src/backends/sage/sagesession.cpp

Loading...