Differential D13660

Enable running commands from the plasmoid
ClosedPublic
Actions

Authored by nicolasfella on Jun 21 2018, 2:55 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:fc4d4e7685d9: Enable running commands from the plasmoid
Summary

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jun 21 2018, 2:55 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJun 21 2018, 2:55 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Jun 21 2018, 2:55 PM
nicolasfella updated this revision to Diff 36467.Jun 21 2018, 2:56 PM
  • Include missing file
nicolasfella edited the summary of this revision. (Show Details)Jun 21 2018, 2:57 PM
apol added a subscriber: apol.Jun 21 2018, 3:13 PM
apol added inline comments.
plasmoid/package/contents/ui/DeviceDelegate.qml
277

This doesn't say much, just remove the comment.

plasmoid/package/contents/ui/RemoteCommands.qml
39

property variant plugin: available ? RemoteCommandsDbusInterfaceFactory.create(device.id()) : null?

apol accepted this revision.Jul 26 2018, 5:35 PM
This revision is now accepted and ready to land.Jul 26 2018, 5:35 PM
Closed by commit R224:fc4d4e7685d9: Enable running commands from the plasmoid (authored by nicolasfella). · Explain WhyJul 27 2018, 6:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38552

View Options

plasmoid/package/contents/ui/DeviceDelegate.qml

Loading...
View Options

plasmoid/package/contents/ui/RemoteCommands.qml

Loading...