Differential D13656

Show release date inline with version string
ClosedPublic
Actions

Authored by ngraham on Jun 21 2018, 2:00 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Commits
R134:c4a74b532cd2: Show release date inline with version string
Summary

The release date is inherently tied to a specific version, so display the two together.

CCBUG: 395677

Test Plan

Also tested apps with no version and apps with a version but no release date; no regressions.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 21 2018, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 21 2018, 2:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 21 2018, 2:00 PM
ngraham edited the test plan for this revision. (Show Details)Jun 21 2018, 2:00 PM
ngraham edited the summary of this revision. (Show Details)
apol added a subscriber: apol.Jun 21 2018, 2:03 PM
apol added inline comments.
discover/qml/ApplicationPage.qml
305

how about:

text: version.length === 0 ? "" 
        : releaseDate.length === 0 ? version
        : i18n("%1, released on %2", version, releaseDate)
apol accepted this revision.Jun 21 2018, 2:06 PM
This revision is now accepted and ready to land.Jun 21 2018, 2:06 PM
ngraham added inline comments.Jun 21 2018, 2:07 PM
discover/qml/ApplicationPage.qml
305

Clever, but IMHO a bit less readable.

Closed by commit R134:c4a74b532cd2: Show release date inline with version string (authored by ngraham). · Explain WhyJun 21 2018, 2:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationPage.qml (30 lines)

Diff 36459

View Options

discover/qml/ApplicationPage.qml

Loading...