PBI has two modes for interacting with media + MPRIS, watching the DOM
tree from it's own JS context for normal controls and a massive
workaround for crossing contexts to shim the Media Sessions API for
getting metadata. We currently inject this on every page.
This patch moves that to only be when we find a valid audio/video
element, reducing work and risk of breakages on most sites.
Page that used to fail now works
Still get thumbnails on media sessions test page
| No Linters Available |
| No Unit Test Coverage |
| Buildable 131 | |
| Build 131: arc lint + arc unit |
An idea how to avoid adding a DOM node altogether
| extension/content-script.js | ||
|---|---|---|
| 419 | Does element.dataset.mediaSessionTransfer work? | |
| 423 | Would it work to dispatchEvent on document.documentElement or document.head? | |
| 484 | Can we use document.documentElement or document.head here | |
| 491 | And use the dataset from above here | |
| extension/content-script.js | ||
|---|---|---|
| 419 | even if it did, you still have DOM manipulation on the executeScript function | |
| extension/content-script.js | ||
|---|---|---|
| 419 | Sure but one thing at a time | |