Differential D13587

[effects] Use more effectData() in BuiltInEffects
ClosedPublic
Actions

Authored by zzag on Jun 18 2018, 12:41 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:7bfaa6e913df: [effects] Use more effectData() in BuiltInEffects
R108:fa5242b3eefd: [effects] Use more effectData() in BuiltInEffects
Summary

While BuiltInEffects has effectData() function, many functions repeat
s_effectData.at(index(effect)), which is what effectData() is doing.

By using effectData(), we'll get rid of those repetitions and maybe make
easier transition to other underlying data structure that stores metadata
for builtin effects.

Test Plan

Compiles, all enabled builtin effects are loaded and working.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 18 2018, 12:41 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 18 2018, 12:41 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 18 2018, 12:41 PM
davidedmundson accepted this revision.Jun 18 2018, 12:46 PM
This revision is now accepted and ready to land.Jun 18 2018, 12:46 PM
Closed by commit R108:7bfaa6e913df: [effects] Use more effectData() in BuiltInEffects (authored by zzag). · Explain WhyJun 18 2018, 1:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/effect_builtins.cpp (23 lines)

Diff 36277

View Options

effects/effect_builtins.cpp

Loading...