Add a workaround for loading broken files with negative frame ids
ClosedPublic
Actions

Authored by dkazakov on Jun 15 2018, 7:32 PM.

Details

Reviewers

jounip
rempt

Group Reviewers

Krita

Commits

Summary

CCBUG:395378

Test Plan

Try to load the file attached to this bugreport:
https://bugs.kde.org/show_bug.cgi?id=395378

Every layer in the file should have two frames (in random order). At least one
of the frames should have sane pixel data

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dkazakov requested review of this revision.Jun 15 2018, 7:32 PM

I have to admit, I have no idea... I would be fine with pushing it, I guess.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2018, 3:21 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libs/image/kis_keyframe_channel.h (1 line)
M			libs/image/kis_keyframe_channel.cpp (30 lines)
M			libs/image/kis_raster_keyframe_channel.cpp (5 lines)
M			libs/image/kis_scalar_keyframe_channel.cpp (4 lines)
M			plugins/tools/tool_transform2/kis_transform_args_keyframe_channel.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36208	47b3cab		Jun 15 2018, 7:32 PM	★	★
Diff 2	39609	3738660	R37:f1452472b9448acad20665eabfe75813c5e4af44	Aug 13 2018, 3:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2cb214ed0658	b40cb5757e0d	47b3cab9f82b	Dmitry Kazakov	Add a workaround for loading broken files with negative frame ids (Show More…)	Jun 15 2018, 7:30 PM