Remove the need to configure QT_PLUGIN_PATH before running Cantor
ClosedPublic
Actions

Authored by sirgienko on Jun 14 2018, 9:56 PM.

Details

Reviewers

Commits

R55:c95d98d79431: Remove the need to configure QT_PLUGIN_PATH before running Cantor by expanding…
R55:54f93b4b949e: Remove the need to configure QT_PLUGIN_PATH before running Cantor by expanding…

Diff Detail

Repository

R55 Cantor

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 39
Build 39: arc lint + arc unit

sirgienko created this revision.Jun 14 2018, 9:56 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 14 2018, 9:56 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

sirgienko requested review of this revision.Jun 14 2018, 9:56 PM

Harbormaster completed remote builds in B29: Diff 36180.Jun 14 2018, 9:56 PM

I have tested this changes with installation path, which contains utf8 symbols (I have used japan language). Also I checked installation in user directory (without sudo)
As I see, all works fine, but Cantor don't install correctly, if path to install is set: we loose Qalculate icon and buttons like "Worksheet evaluate", "Interapt Calculation", etc.
I think, I fix it soon.

Move code from backend.cpp to main.cpp: it guaranteeses, that plugin path will be modified before using

Harbormaster completed remote builds in B37: Diff 36198.Jun 15 2018, 11:27 AM

Fix comment messages

Harbormaster completed remote builds in B39: Diff 36200.Jun 15 2018, 12:16 PM

asemke accepted this revision.Jun 15 2018, 5:04 PM

This revision is now accepted and ready to land.Jun 15 2018, 5:04 PM

Closed by commit R55:54f93b4b949e: Remove the need to configure QT_PLUGIN_PATH before running Cantor by expanding… (authored by sirgienko). · Explain WhyJun 15 2018, 5:07 PM

This revision was automatically updated to reflect the committed changes.

sirgienko mentioned this in T3872: Create unit tests for each backend.Jun 17 2018, 12:14 PM

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			src/main.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36180	2fae896		Jun 14 2018, 9:54 PM	★	★
Diff 2	36198	2fae896	Move code from backend.cpp to main.cpp: it guaranteeses, that plugin path will…	Jun 15 2018, 11:27 AM	★	★
Diff 3	36200	2fae896	Fix comment messages	Jun 15 2018, 12:16 PM	★	★
Diff 4	36207	2fae896	R55:54f93b4b949e6b8e8222776f4681eb4bba3aa147	Jun 15 2018, 5:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9895b9bf8c8b	431bf51d0f0f	2fae89611bf8	Nikita Sirgienko	Remove the need to configure QT_PLUGIN_PATH before running Cantor by expanding… (Show More…)	Jun 14 2018, 9:49 PM

Diff 36200

View Options