Differential D1354

unit tests for extracting file/line from messages produced by javac with ant
ClosedPublic
Actions

Authored by zhanghuijie on Apr 8 2016, 7:01 AM.

Details

Reviewers
kfunk
Commits
R32:708228e1333d: unit tests for extracting file/line from messages produced by javac with ant
R33:708228e1333d: unit tests for extracting file/line from messages produced by javac with ant

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zhanghuijie updated this revision to Diff 3208.Apr 8 2016, 7:01 AM
zhanghuijie retitled this revision from to unit tests for extracting file/line from messages produced by javac with ant.
zhanghuijie updated this object.
zhanghuijie edited the test plan for this revision. (Show Details)
zhanghuijie added a reviewer: kfunk.
zhanghuijie set the repository for this revision to R33 KDevPlatform.
zhanghuijie added a subscriber: KDevelop.
bcooksley changed the visibility from "All Users" to "Public (No Login Required)".Apr 8 2016, 7:52 PM
bcooksley added a subscriber: bcooksley.

Please don't restrict the visibility or editability of reviews which are posted on KDE Code Review tools such as Phabricator.
I've now reset the permissions to view and edit this review to the appropriate settings.

kfunk accepted this revision.Apr 8 2016, 8:07 PM
kfunk edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 8 2016, 8:07 PM
zhanghuijie added a comment.Apr 9 2016, 12:42 AM
In D1354#25349, @bcooksley wrote:

Please don't restrict the visibility or editability of reviews which are posted on KDE Code Review tools such as Phabricator.
I've now reset the permissions to view and edit this review to the appropriate settings.

Sorry for this, I am new to phabricator :).

Closed by commit R33:708228e1333d: unit tests for extracting file/line from messages produced by javac with ant (authored by zhanghuijie). · Explain WhyApr 9 2016, 1:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3228

View Options

outputview/tests/filteringstrategytest.cpp

Loading...