Differential D13539

Simplify saveShortcuts and saveFavorites
ClosedPublic
Actions

Authored by tcanabrava on Jun 14 2018, 2:38 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:5c0a5fd496e9: Simplify saveShortcuts and saveFavorites
Summary

Great part of the code inside saveShortcuts and saveFavorites
is similar, extract it to a new function and call it.

Test Plan

Edited shortcuts, saved, saves where correct.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jun 14 2018, 2:38 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 14 2018, 2:38 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 14 2018, 2:38 PM
tcanabrava edited the test plan for this revision. (Show Details)Jun 14 2018, 2:39 PM
tcanabrava added reviewers: hindenburg, Konsole.
hindenburg accepted this revision.Jun 16 2018, 6:26 PM

Thanks, if there's only one commit I'll go ahead and land them.

This revision is now accepted and ready to land.Jun 16 2018, 6:26 PM
Closed by commit R319:5c0a5fd496e9: Simplify saveShortcuts and saveFavorites (authored by tcanabrava, committed by hindenburg). · Explain WhyJun 16 2018, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ProfileManager.h (4 lines)
Msrc/ProfileManager.cpp (74 lines)

Diff 36238

View Options

src/ProfileManager.h

Loading...
View Options

src/ProfileManager.cpp

Loading...