Differential D13527

[effects/fallapart] Fix flickering problem
ClosedPublic
Actions

Authored by zzag on Jun 14 2018, 10:03 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:5daa612bce74: [effects/fallapart] Fix flickering problem
Summary

The Fall Apart effect doesn't grab windows so a conflict could happen
if an alternative window open/close animation effect is enabled(e.g.
Fade, Glide).

Before

Fall apart and Fade conflict with each other.

After

Only Fall apart animates the disappearing of System Settings.

Test Plan
  • Enabled fall apart effect and fade effect
  • Closed a window

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 14 2018, 10:03 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 14 2018, 10:03 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 14 2018, 10:03 AM
zzag edited the summary of this revision. (Show Details)Jun 14 2018, 10:03 AM
zzag edited the summary of this revision. (Show Details)Jun 14 2018, 10:06 AM
zzag edited the summary of this revision. (Show Details)Jun 14 2018, 10:12 AM
zzag edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jun 14 2018, 10:13 AM
This revision is now accepted and ready to land.Jun 14 2018, 10:13 AM
Closed by commit R108:5daa612bce74: [effects/fallapart] Fix flickering problem (authored by zzag). · Explain WhyJun 14 2018, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36139

View Options

effects/fallapart/fallapart.h

Loading...
View Options

effects/fallapart/fallapart.cpp

Loading...