Correctly translate combo box in media frame plasmoid
ClosedPublic

Authored by davidedmundson on Apr 8 2016, 12:36 AM.

Details

Summary

ListElement doesn't support script values. The original code used a
"stupid hack" to try and run i18n later, but that doesn't work as we
haven't extracted the original text.

Porting to a Javascript map works (and is the approach taken by the main
image wallpaper for a similar model)

Introduces a lot of new strings being extracted properly.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Correctly translate combo box in media frame plasmoid.
davidedmundson updated this object.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2016, 12:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Apr 8 2016, 6:25 AM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.

Maybe add context to the strings?

This revision is now accepted and ready to land.Apr 8 2016, 6:25 AM
This revision was automatically updated to reflect the committed changes.