Differential D13512

Cleanup IncrementalSearchBar
ClosedPublic
Actions

Authored by tcanabrava on Jun 13 2018, 11:14 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:71e9bb5d60e0: Return early - minimize if indentation
Summary

Random code cleanup to IncrementalSearchBar to simplify future maintenance.

Diff Detail

Repository
R319 Konsole
Branch
incrementalSearchBarCodeModernization
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava created this revision.Jun 13 2018, 11:14 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 13 2018, 11:14 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 13 2018, 11:14 AM
tcanabrava updated this revision to Diff 36094.Jun 13 2018, 11:21 AM
  • Clean setFoundMatch
tcanabrava retitled this revision from Return early - minimize if indentation to Cleanup IncrementalSearchBar.Jun 13 2018, 11:23 AM
tcanabrava edited the summary of this revision. (Show Details)
tcanabrava added reviewers: Konsole, hindenburg.
hindenburg accepted this revision.Jun 17 2018, 1:58 AM
This revision is now accepted and ready to land.Jun 17 2018, 1:58 AM

Revision Contents
Changeset List

PathPackages
Msrc/IncrementalSearchBar.cpp (123 lines)

Diff 36094

View Options

src/IncrementalSearchBar.cpp

Loading...