Checking whether the m_textTexture is not null before dereferencing it
ClosedPublic
Actions

Authored by ivan on Apr 7 2016, 6:03 PM.

Details

Reviewers

graesslin

Commits

Summary

It can be null even after updateTextTexture() if there is not text
to generate the texture from:

if (m_effectFrame->text().isEmpty())
    return;

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ivan retitled this revision from to Checking whether the m_textTexture is not null before dereferencing it.

ivan updated this object.

ivan edited the test plan for this revision. (Show Details)

ivan added a reviewer: graesslin.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Interestingly we have never seen this one being a problem over the last few years, so in reality the text never is empty.

This revision is now accepted and ready to land.Apr 8 2016, 6:01 AM

That is what static analysis is for - to catch bugs that have not been exposed yet :)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			scene_opengl.cpp (9 lines)
M			scene_xrender.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3198	7996d95		Apr 7 2016, 6:03 PM	★	★
Diff 2	3210	2c95a4e	rKWINf06dff3390b6638b980266ac5676b2e7503f1ae8	Apr 8 2016, 7:26 AM	★	★