Fix build on platforms where sizeof(int) == sizeof(long)
AbandonedPublic

Authored by dvratil on Jun 9 2018, 10:39 PM.

Details

Reviewers
mwolff
Summary

Fix build on platforms where unsigned and unsigned long are the same sizes, which makes the clz() overload ambiguous.

On platforms where sizeof(long) == 4, qint64 must be processed with __builtin_clzll()

Test Plan

Successfully built and used heaptrack on an armv7 target.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
dvratil requested review of this revision.Jun 9 2018, 10:39 PM
dvratil created this revision.

Isn't this fixed in master and 1.1 branch (after the 1.1 release) already?
76fd2e84ba133e96d2cfdf90cb715e66e923eb8f and 49577e019ea791ee63962cdfe7e9c0c5b5c6ea4b ?

dvratil abandoned this revision.Jun 13 2018, 12:22 PM

Bummer, I only checked the v1.1.0 tag :)