- newPlot -> addPlot
- deletePlot -> removePlot
- update is now called when appendPoint is called and is private.
- QStringList plots () returns list of plots.
- setMaximumTemperature to set the Y cap
- setMaximumPoints to set how much data to hold
- Solve memory leak (by holding only so much data per point)
- No longer start with any point. (this frees clients to add them based on the device)
- Adjust test gui for these changes.
Details
Details
- Reviewers
tcanabrava - Group Reviewers
Atelier: AtCore - Commits
- R232:3c44a682bb17: Improve the Plotwidget
R232:903d27d9af0b: Improve the Plotwidget
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Branch
- plotImprove
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/widgets/plotwidget.cpp | ||
---|---|---|
27–29 | those can be on the stack? | |
70–71 | I really don't like the double map. | |
82–85 | everytime you call .keys() you generate a new list appending things in a temporary. if the keys never change we should store this value somewhere. | |
src/widgets/plotwidget.h | ||
63–76 | const | |
81 | why explicit when it has no parameters? | |
129–130 | QByteArray on the hash if used without UTF8 strings |
src/widgets/plotwidget.cpp | ||
---|---|---|
82–85 | This widget is created with no keys. We do not know how many clients will add. |
src/widgets/plotwidget.cpp | ||
---|---|---|
32–33 | dude, move this back to the initializer list, and pass 'this' there. :) |