Differential D13364

Correctly list the open programs when trying to quit
ClosedPublic
Actions

Authored by tcanabrava on Jun 5 2018, 4:35 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:6ca007fcb326: Correctly list the open programs when trying to quit
Summary

Uniquely iterate over the sessions instead of checking
for all sessions inside of a terminal window. The tabs in
split view will have duplicate sessions.

Test Plan

Open Konsole, run any application that will not quit, like top
split screen, duplicating the Views, close konsole.

top will appear in the list of applications that are opened twice.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jun 5 2018, 4:35 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 5 2018, 4:35 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 5 2018, 4:35 PM
tcanabrava edited the summary of this revision. (Show Details)Jun 5 2018, 4:37 PM
tcanabrava edited the test plan for this revision. (Show Details)
tcanabrava added a reviewer: Konsole.
hindenburg accepted this revision.Jun 8 2018, 3:02 AM

Nice, thanks

This revision is now accepted and ready to land.Jun 8 2018, 3:02 AM
hindenburg edited the summary of this revision. (Show Details)Jun 8 2018, 3:05 AM
Closed by commit R319:6ca007fcb326: Correctly list the open programs when trying to quit (authored by tcanabrava, committed by hindenburg). · Explain WhyJun 8 2018, 3:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/MainWindow.cpp (4 lines)

Diff 35816

View Options

src/MainWindow.cpp

Loading...