[Installation Reminder] Watch for service registration and hide
ClosedPublic
Actions

Authored by broulik on May 30 2018, 9:00 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

In case the browser takes forever to start or user installs the extension manually without clicking the SNI.

CCBUG: 394673

Test Plan

Started Firefox, waited for the SNI to show up, installed extension manually, SNI disappeared and module unloaded

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.May 30 2018, 9:00 AM

davidedmundson added inline comments.

reminder/browserintegrationreminder.cpp
140	technically best to move this above the check for isServiceRegistered and you avoid the slim race possibility.

This revision is now accepted and ready to land.May 30 2018, 9:45 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			reminder/browserintegrationreminder.h (1 line)
M			reminder/browserintegrationreminder.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35175			May 30 2018, 8:59 AM	★	★
Diff 2	35316	f8e5eba	R856:4f5eeec505e8a401331db0b5a3e17416f63590b0	Jun 1 2018, 10:44 AM	★	★