Differential D13185

Make the string 'No touchpad found' translatable
ClosedPublic
Actions

Authored by yurchor on May 29 2018, 4:29 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Localization
Commits
R119:9c5d8bfd66a4: Make the string 'No touchpad found' translatable
Summary

If there are no touchpads installed, Touchpad KCM shows a big red untranslatable banner on its main page: "No touchpad found". The string was translated earlier, so no additional strings should be translated if the patch is landed.

This was once pushed but has been reverted the next day.

Test Plan

All similar strings in the same file are translatable. Nothing should be tested.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.May 29 2018, 4:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2018, 4:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.May 29 2018, 4:29 AM
broulik accepted this revision.May 29 2018, 6:08 AM
broulik added a subscriber: broulik.

Making previously erroneously untranslated strings translatable is always allowed, they're not "new strings" as far as this rule is concerned

This revision is now accepted and ready to land.May 29 2018, 6:08 AM
Closed by commit R119:9c5d8bfd66a4: Make the string 'No touchpad found' translatable (authored by yurchor). · Explain WhyMay 29 2018, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35127

View Options

kcms/touchpad/src/backends/x11/xlibbackend.cpp

Loading...