Differential D13125

Refine tab bar settings UI string
ClosedPublic
Actions

Authored by jfredrickson on May 26 2018, 2:31 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:3e42f1177ae2: Refine tab bar settings UI string
Summary

Make the Qt 5.9 sentence present tense since we already
passed that version, and add a minor grammar update.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jfredrickson created this revision.May 26 2018, 2:31 AM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 26 2018, 2:31 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
jfredrickson requested review of this revision.May 26 2018, 2:31 AM
jfredrickson added a comment.May 26 2018, 2:48 AM

Also, I wonder if this string should be removed entirely?

Before:


After:

ngraham added subscribers: hindenburg, ngraham.May 26 2018, 2:59 AM

Considering that Qt 5.9 is the minimum version (for Plasma at least), I'd say it's safe to remove that label in master. @hindenburg's call, of course.

hindenburg added a comment.May 26 2018, 1:19 PM

Konsole and other apps can be used w/o plasma - I go by the frameworks minimum versions which is still Qt 5.6 the last time I checked

Thanks for the patch, I'll look at it shortly

hindenburg accepted this revision.May 28 2018, 12:09 PM
This revision is now accepted and ready to land.May 28 2018, 12:09 PM
hindenburg edited the summary of this revision. (Show Details)May 28 2018, 12:10 PM
Closed by commit R319:3e42f1177ae2: Refine tab bar settings UI string (authored by hindenburg). · Explain WhyMay 28 2018, 12:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/settings/TabBarSettings.ui (2 lines)

Diff 35020

View Options

src/settings/TabBarSettings.ui

Loading...