Fix Cmake and Folder Structure
ClosedPublic
Actions

Authored by tcanabrava on May 25 2018, 2:34 PM.

Details

Reviewers

Commits

R232:570cfccc9877: Fix Cmake and Folder Structure

Summary

Fixes cmake to correctly export AtCoreWidgets on the AtCore namespace
Moved core sources to the core/ subdirectory
fixed paths and assorted cmake's misusages.

Diff Detail

Repository

R232 AtCore

Branch

fix_everything

Lint

No Linters Available

Unit

No Unit Test Coverage

tcanabrava requested review of this revision.May 25 2018, 2:34 PM

tcanabrava created this revision.

While this does not fix installing from /usr/local it does resolve T8593 and should fix T8650

This revision is now accepted and ready to land.May 25 2018, 7:42 PM

rizzitello mentioned this in T8593: Fix AtCoreWidget Prefix.May 25 2018, 8:30 PM

rizzitello mentioned this in D13127: Adjust for AtCorePrefix.May 26 2018, 3:59 AM

Merged.

rizzitello mentioned this in R231:b82b1cd75198: Adjust for AtCorePrefix.May 28 2018, 11:58 AM

Revision Contents
Changeset List

			Path	Packages
V			{ → src/core}/AtCoreConfig.cmake.in (7 lines)
M			CMakeLists.txt (59 lines)
P			src/CMakeLists.txt (71 lines) Copied to src/core/CMakeLists.txt
V			src/{ → core}/atcore.h (557 lines)
V			src/{ → core}/atcore.cpp (778 lines)
V			src/{ → core}/atcore_default_folders.h.in (31 lines)
V			{src/core ← }/AtCoreConfig.cmake.in (7 lines)
P			src/core/CMakeLists.txt (52 lines) Copied from src/CMakeLists.txt
V			src/{core ← }/atcore.h (557 lines)
V			src/{core ← }/atcore.cpp (778 lines)
V			src/{core ← }/atcore_default_folders.h.in (31 lines)
V			src/{core ← }/gcodecommands.h (144 lines)
V			src/{core ← }/gcodecommands.cpp (564 lines)
V			src/{core ← }/ifirmware.h (92 lines)
V			src/{core ← }/ifirmware.cpp (76 lines)
V			src/{core ← }/printthread.h (153 lines)
V			src/{core ← }/printthread.cpp (227 lines)
V			src/{core ← }/seriallayer.h (124 lines)
V			src/{core ← }/seriallayer.cpp (151 lines)
V			src/{core ← }/temperature.h (129 lines)
V			src/{core ← }/temperature.cpp (137 lines)
V			src/{ → core}/gcodecommands.h (144 lines)
V			src/{ → core}/gcodecommands.cpp (564 lines)
V			src/{ → core}/ifirmware.h (92 lines)
V			src/{ → core}/ifirmware.cpp (76 lines)
M			src/plugins/CMakeLists.txt (4 lines)
V			src/{ → core}/printthread.h (153 lines)
V			src/{ → core}/printthread.cpp (227 lines)
V			src/{ → core}/seriallayer.h (124 lines)
V			src/{ → core}/seriallayer.cpp (151 lines)
V			src/{ → core}/temperature.h (129 lines)
V			src/{ → core}/temperature.cpp (137 lines)
M			src/widgets/CMakeLists.txt (55 lines)