Differential D13108

[Global Menu Applet] Open menu on press
ClosedPublic
Actions

Authored by broulik on May 25 2018, 10:54 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:26045ba5358e: [Global Menu Applet] Open menu on press
Summary

Adds a MouseArea so it opens on press like QMenu does.
It just forward to clicked since this is called from various places (keyboard nav, Alt activation, etc)

Test Plan

5.13 branch
Menu opens on press, and I can now do the press-move-release dance to select an item.
Also increases perceived menu performance

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 25 2018, 10:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 25 2018, 10:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 25 2018, 10:54 AM
davidedmundson accepted this revision.May 25 2018, 10:57 AM
davidedmundson added inline comments.
applets/appmenu/package/contents/ui/main.qml
143

That's a very smart solution (or thoroughly mad, I can't tell)

This revision is now accepted and ready to land.May 25 2018, 10:57 AM
Closed by commit R120:26045ba5358e: [Global Menu Applet] Open menu on press (authored by broulik). · Explain WhyMay 25 2018, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34856

View Options

applets/appmenu/package/contents/ui/main.qml

Loading...