Differential D13087

[FocusRect] Use manual placement instead of anchors
ClosedPublic
Actions

Authored by broulik on May 24 2018, 8:57 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R858:ec06b3bc2f98: [FocusRect] Use manual placement instead of anchors
Summary

I thought I was smart by using anchors that get auto-mirroring but leftPadding of the control already took that into account leading to double mirroring undoing the effect.

Test Plan

Ran in qmlscene -reverse and focus rect is properly aligned in Breeze and Windows style. Left-to-right is still correct

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 24 2018, 8:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 24 2018, 8:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 24 2018, 8:57 AM
mart accepted this revision.May 24 2018, 9:24 AM
This revision is now accepted and ready to land.May 24 2018, 9:24 AM
Closed by commit R858:ec06b3bc2f98: [FocusRect] Use manual placement instead of anchors (authored by broulik). · Explain WhyMay 24 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34791

View Options

org.kde.desktop/private/FocusRect.qml

Loading...