Differential D13069

[Task Manager] Fix URL comparison
ClosedPublic
Actions

Authored by broulik on May 23 2018, 4:36 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:f7516196cfa4: [Task Manager] Fix URL comparison
Summary

You cannot compare to null but to empty string.
This was done to disable "Pin" when no launcher URL is available but not properly executed in "Start New Instance"

Test Plan

5.12 branch

  • "Launch new instance" is now disabled for e.g. wine notepad where it wouldn't work anyway (second change)
  • "Pin" is still properly checked depending on whether the task is pinned or not (first change)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 23 2018, 4:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2018, 4:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2018, 4:36 PM
hein accepted this revision.May 23 2018, 4:37 PM
This revision is now accepted and ready to land.May 23 2018, 4:37 PM
Closed by commit R119:f7516196cfa4: [Task Manager] Fix URL comparison (authored by broulik, committed by hein). · Explain WhyMay 23 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34731

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...