GrantleeHeaderFormatter: Move list and date formatter into grantlee.
ClosedPublic
Actions

Authored by knauss on May 22 2018, 1:03 PM.

Details

Reviewers

vkrause
mlaurent

Commits

Summary

With this we have a more clean interface, what we can do with
AddressLists and Dates and to not blown the namespace.

Currently I'm very unhappy with the code duplication for Mailboxes and
QShardPointer. Maybe someone can help me to improve this.

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

knauss requested review of this revision.May 22 2018, 1:03 PM

This revision is now accepted and ready to land.Aug 17 2018, 9:29 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			messageviewer/src/header/autotests/data/bcctest.tmpl (10 lines)
M			messageviewer/src/header/autotests/data/bcctest.tmpl.html (6 lines)
M			messageviewer/src/header/autotests/data/cctest.tmpl (10 lines)
M			messageviewer/src/header/autotests/data/cctest.tmpl.html (4 lines)
M			messageviewer/src/header/autotests/data/datetest.tmpl (12 lines)
M			messageviewer/src/header/autotests/data/fromtest.tmpl (8 lines)
M			messageviewer/src/header/autotests/data/fromtest.tmpl.html (6 lines)
M			messageviewer/src/header/autotests/data/replyTotest.tmpl (10 lines)
M			messageviewer/src/header/autotests/data/replyTotest.tmpl.html (6 lines)
M			messageviewer/src/header/autotests/data/resentfromtest.tmpl (10 lines)
M			messageviewer/src/header/autotests/data/resentfromtest.tmpl.html (10 lines)
M			messageviewer/src/header/autotests/data/resenttotest.tmpl (10 lines)
M			messageviewer/src/header/autotests/data/resenttotest.tmpl.html (10 lines)
M			messageviewer/src/header/autotests/data/totest.tmpl (8 lines)
M			messageviewer/src/header/autotests/data/totest.tmpl.html (4 lines)
M			messageviewer/src/header/grantleeheaderformatter.cpp (212 lines)
M			messageviewer/src/header/headerstyle_util.h (13 lines)
M			messageviewer/src/header/headerstyle_util.cpp (89 lines)
M			messageviewer/src/header/plainheaderstyle.cpp (10 lines)
M			messageviewer/src/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/theme/5.2/header.html (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34642	fdc3496		May 22 2018, 1:03 PM	★	★
Diff 2	42188	8c82259	R94:e6f82b5b2c03d3683d56ac975bf65d0504fed822	Sep 23 2018, 9:09 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
06146c3d72a4	6d3b44a9253b	fdc349659df4	Sandro Knauß	GrantleeHeaderFormatter: Move list and date formatter into grantlee. (Show More…)	May 22 2018, 12:34 PM