Differential D12995

add basic kdiff3 man page
ClosedPublic
Actions

Authored by lueck on May 20 2018, 11:39 AM.

Details

Reviewers
mreeves
ltoscano
Group Reviewers
Documentation
Commits
R983:d88b7995c344: add basic kdiff3 man page
Summary

add man page written using kf5 man-docbook template and the output of kdiff3 -h in kf5
change target dir for handbook

Test Plan

checkXML5 doc/en/man-kdiff3.1.docbook
build + install

Diff Detail

Repository
R983 KDiff3
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.May 20 2018, 11:39 AM
Restricted Application added a project: Documentation. · View Herald TranscriptMay 20 2018, 11:39 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
lueck requested review of this revision.May 20 2018, 11:39 AM
ltoscano added a subscriber: ltoscano.May 20 2018, 9:49 PM

Looks generally fine.

doc/en/CMakeLists.txt
2

KDE_INSTALL_MANDIR ?

doc/en/man-kdiff3.1.docbook
194

It looks like the KF5 options do not work right now, probably the code needs to be fixed.

mreeves added a comment.May 20 2018, 10:01 PM

I'll have a look at the kf5 options.

mreeves added inline comments.May 21 2018, 12:16 AM
doc/en/man-kdiff3.1.docbook
194

Should be fixed in master.

mreeves added inline comments.May 21 2018, 12:21 AM
doc/en/CMakeLists.txt
2

Looks like yes. See D11697

lueck updated this revision to Diff 34560.May 21 2018, 7:25 AM

use correct manpage install target

lueck marked 2 inline comments as done.May 22 2018, 7:13 PM
ltoscano added a comment.May 22 2018, 7:27 PM

It looks good to me. Now let's wait for @mreeves

lueck added a comment.May 23 2018, 8:28 PM

someone needs to accept this, right?

ltoscano accepted this revision as: ltoscano.May 23 2018, 9:49 PM

Rrrright

This revision is now accepted and ready to land.May 23 2018, 9:49 PM
Closed by commit R983:d88b7995c344: add basic kdiff3 man page (authored by lueck). · Explain WhyMay 24 2018, 4:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdoc/en/CMakeLists.txt (3 lines)
AMdoc/en/man-kdiff3.1.docbook (203 lines)

Diff 34769

View Options

doc/en/CMakeLists.txt

Loading...
View Options

doc/en/man-kdiff3.1.docbook

Loading...