Differential D12965

Modernize: Remove 'this->'
ClosedPublic
Actions

Authored by tcanabrava on May 18 2018, 3:03 PM.

Tags

Subscribers

hindenburg, konsole-devel

Details

Reviewers

Group Reviewers

Commits

R319:58a9311bcba6: Modernize: Remove 'this->'

Summary

This is not userfully, only adds more code and
the code is happy without it.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tcanabrava created this revision.May 18 2018, 3:03 PM

Restricted Application added a project: Konsole. · View Herald TranscriptMay 18 2018, 3:03 PM

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

tcanabrava requested review of this revision.May 18 2018, 3:03 PM

tcanabrava added a reviewer: Konsole.May 18 2018, 3:04 PM

Thanks, I don't recall why these were used at the time.

This revision is now accepted and ready to land.May 23 2018, 12:46 AM

Closed by commit R319:58a9311bcba6: Modernize: Remove 'this->' (authored by tcanabrava, committed by hindenburg). · Explain WhyMay 23 2018, 1:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/HistorySizeWidget.cpp (2 lines)
M			src/Session.cpp (16 lines)
M			src/TerminalDisplay.cpp (30 lines)
M			src/ViewContainerTabBar.cpp (2 lines)
M			src/ViewManager.cpp (16 lines)
M			src/settings/GeneralSettings.cpp (2 lines)

Diff 34680

src/HistorySizeWidget.cpp

Loading...

src/Session.cpp

Loading...

src/TerminalDisplay.cpp

Loading...

src/ViewContainerTabBar.cpp

Loading...

src/ViewManager.cpp

Loading...

src/settings/GeneralSettings.cpp

Loading...