KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla
ClosedPublic

Authored by kkofler on May 13 2018, 10:02 AM.

Details

Summary

Implement migration of passwords stored in KWallet or GNOME Keyring from
QupZilla to Falkon.

The logic is the same as for the profiles: If no "Falkon" folder exists,
but a "QupZilla" folder exists, we read all the data from the "QupZilla"
folder and write it to the "Falkon" folder. (In GNOME Keyring, those are
not actually folders, but application attributes on the entries, but the
logic is the same.)

In GnomeKeyringPasswordBackend, a storeEntry helper method is introduced
to avoid duplicating code.

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kkofler created this revision.May 13 2018, 10:02 AM
Restricted Application added a subscriber: falkon. · View Herald TranscriptMay 13 2018, 10:02 AM
kkofler requested review of this revision.May 13 2018, 10:02 AM

Note: This patch is against Falkon/3.0. (The profile migration was added in 3.0.1, so I think this is also 3.0 material.) For master, the KWalletPasswords changes have to move to KDEFrameworkIntegration.

drosca accepted this revision.May 13 2018, 10:10 AM
This revision is now accepted and ready to land.May 13 2018, 10:10 AM
This revision was automatically updated to reflect the committed changes.

Are you going to do the merge of my changes to master or shall I do it?