Differential D12822

Added null check in OverlayDrawer
AbandonedPublic
Actions

Authored by apol on May 11 2018, 10:08 AM.

Details

Reviewers
Dax
Summary

This patch checks if 'header' property is valid

Tested with Qt 5.10.1 on Android

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
Dax created this revision.May 11 2018, 10:08 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptMay 11 2018, 10:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Dax requested review of this revision.May 11 2018, 10:08 AM
apol added a subscriber: apol.May 12 2018, 11:21 AM

Already done in https://phabricator.kde.org/D12741.

Or I'm missing something?

Dax added a comment.May 13 2018, 7:46 AM

Yes it's the same one!

mart added a subscriber: mart.May 14 2018, 9:05 AM

ok this can be abandoned then

apol commandeered this revision.May 14 2018, 10:58 AM
apol abandoned this revision.
apol added a reviewer: Dax.

Revision Contents
Changeset List

Diff 33983

View Options

src/controls/templates/OverlayDrawer.qml

Loading...