Differential D12819

Fix the global drawer handle "click"
ClosedPublic
Actions

Authored by lepagevalleeemmanuel on May 11 2018, 8:02 AM.

Details

Reviewers
davidedmundson
mart
Commits
R169:62ccb0ed7001: drawer: Display the content widget when dragging.
Summary

Bug:

  • drawerOpen is not set when dragging manually
  • Widgets using a Loader{} active on drawerOpen || peeking are shown only when clicked or during peeking, not after the drawer is dragged open

Step to reproduce:

  • Drag manually the drawer to open
  • Click on the handle
  • Notice it takes 2 click to close it

Ref: https://github.com/ring-project/ring/issues/49

Test Plan
  • Manual testing

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Kirigami. · View Herald TranscriptMay 11 2018, 8:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
lepagevalleeemmanuel requested review of this revision.May 11 2018, 8:02 AM
mart accepted this revision.May 11 2018, 3:39 PM
This revision is now accepted and ready to land.May 11 2018, 3:39 PM
Closed by commit R169:62ccb0ed7001: drawer: Display the content widget when dragging. (authored by lepagevalleeemmanuel). · Explain WhyAug 6 2018, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39205

View Options

src/controls/templates/OverlayDrawer.qml

Loading...