Details
- Reviewers
vonreth
Diff Detail
- Repository
- R877 Craft Blueprints for KDE
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Cool, but what about MSVC? On Linux I have two packages gpgmepp and KF5-gpgmepp. For KMyMoney, the first one is searched and the second one is a fallback. This patch adds KF5-gpgmepp, so it should work on MSVC as well. Is it OK for you?
gpgmepp was once a KDE project but it was merged into gpgme.
So for now there is no way to get gpgme besides providing a cmake patch to gpgmepp
It's dead but it is better than nothing. Modern Linux distros provide KF5-gpgmepp and I can build it against KMyMoney, so maybe we should allow it as intermittent solution for MSVC.
Yes, but we don't loose nothing by trying. In case, it wouldn't work, we can remove it. Is it ok to commit it into that place?
As I can see, your gpgmepp has issues as well :)
- What about MinGW build? It fails constantly on your gpgmepp. Do I have to provide a option to make it compile right?
- What about this review? Are you OK with me commiting it to the location I suggested?
For the error you get in kmymoney.
We need to patch the cmake config to be relocatable and to not include msys install paths, if it gets to complicated a postInstall rutine to patch the file would be ok.
For this patch, it doesn't even build with msvc so I don't accept the patch.
It seems, that it has never been designed to work on MSVC. It fails on inclusion of sys/time.h.