kerfuffle/cliinterface.cpp
723 ↗	(On Diff #3036)	Some kind of input validation would be useful here. Say that the level is negative (should not happen, but who knows), in that case the function should return an empty list (and the plugin would then use whatever the default level is.

This revision now requires changes to proceed.Mar 31 2016, 9:51 AM

kerfuffle/cliinterface.h
155 ↗	(On Diff #3036)	Should we change this one to a QString?

Set compression level from CompressionOptions. Now we just need to implement the GUI.

Add an assert to CliInterface::compressionLevelSwitch() which checks that the compression level is between 0 and 9.

rthomsen marked an inline comment as done.Apr 6 2016, 6:39 PM

An error crept into the previous diff.

elvisangelaccio edited edge metadata.

elvisangelaccio added inline comments.

kerfuffle/cliinterface.h
155 ↗	(On Diff #3036)	Yes, makes sense.

This revision is now accepted and ready to land.Apr 6 2016, 8:53 PM

Change CompressionLevelSwitch parameter from QStringList to QString.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/plugins/cli7zplugin/cli7ztest.cpp (20 lines)
M			autotests/plugins/clirarplugin/clirartest.cpp (20 lines)
M			kerfuffle/cliinterface.h (14 lines)
M			kerfuffle/cliinterface.cpp (27 lines)
M			plugins/cli7zplugin/cliplugin.cpp (2 lines)
M			plugins/clirarplugin/cliplugin.cpp (2 lines)
M			plugins/clizipplugin/cliplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3036			Mar 30 2016, 8:47 PM	★	★
Diff 2	3174			Apr 6 2016, 6:35 PM	★	★
Diff 3	3175			Apr 6 2016, 6:42 PM	★	★
Diff 4	3183			Apr 7 2016, 6:21 AM	★	★
Diff 5	3196	62deece	rARK8a770f7ba895c2c15885ee6040c384736060d9dc	Apr 7 2016, 5:35 PM	★	★

Enable support for setting compression level in cliplugins
ClosedPublic
Actions

Details