TaskManager: Group tasks when losing demands attention state
ClosedPublic

Authored by drosca on Mar 30 2016, 8:03 PM.

Details

Summary

When new task is added to GroupManager, it will be ungrouped
if the task demands attention. Group it back again once it loses
demands attention state.

Test Plan

When there is more than one task demanding attention of
one program, all tasks of that program gets grouped once one of the
program's tasks loses attention. I'm not sure how to fix that, otherwise
it seems to work fine.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 3035.Mar 30 2016, 8:03 PM
drosca retitled this revision from to TaskManager: Group tasks when losing demands attention state.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2016, 8:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca updated this revision to Diff 3042.Mar 31 2016, 7:36 AM

Always connect to windowChanged

hein accepted this revision.Mar 31 2016, 8:58 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2016, 8:58 AM
drosca updated this revision to Diff 3244.Apr 9 2016, 3:13 PM
drosca edited edge metadata.

Use handleItem instead of remove+add to prevent moving the task to the end of task list

hein added a comment.Apr 11 2016, 4:30 PM

Looks good.

This revision was automatically updated to reflect the committed changes.